Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Release Package Publication #5963

Merged
merged 47 commits into from
Jan 7, 2022

Conversation

nimanch
Copy link
Contributor

@nimanch nimanch commented Jan 5, 2022

The PR Adds

  1. Script for Automated Release Package Publication to Microsoft Packaging Service. The Script does the following
    a. Downloads Docker Image for making API Calls to Microsoft Packaging Service
    b. Pushes the Packages
    c. Checks the Status of Upload
  2. YAML Stage that
    a. Waits for Approval before beginning Publish
    b. Downloads Artifacts from Current Build
    c. Download IIS Artifact from Corresponding IIS Commit
    d. Run the Above Script

Testing

  1. Test 1 Package Build and Make sure can call service (No Upload) : https://msazure.visualstudio.com/One/_build/results?buildId=50560523&view=results
  2. Locally Tested Script for Upload of ubuntu 20.04 Packages
  3. Running Test with all packages and check if can reach service: https://msazure.visualstudio.com/One/_build/results?buildId=50577327&view=logs&j=9ee4c831-88c8-5b21-03bd-e584eea512b1&t=8b71f7b1-d932-547e-3e2f-82f1a8357422

TODO

  1. After Test - Enable Package Upload Code

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

nimanch and others added 30 commits October 7, 2021 04:21
This PR Re-enables Rust Coverage in Check in Pipelines
1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines
2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin)
3. Publish HTML Code Coverage Report Based on Coverage Report


Note : The Current Code Coverage stands at 44%.  I had to reduce the code coverage gate for Rust to 44%.  The intent is to increase the code coverage and then increase the gate.

Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
@nimanch nimanch changed the title Automate Publication of Release Packages Automation Release Package Publication Jan 7, 2022
@nimanch nimanch marked this pull request as ready for review January 7, 2022 16:06
Copy link
Member

@damonbarry damonbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll hold off on approving though, since it will get reset anyway when you uncomment stuff after testing.

@nimanch
Copy link
Contributor Author

nimanch commented Jan 7, 2022

Looks good! I'll hold off on approving though, since it will get reset anyway when you uncomment stuff after testing.

Thanks!, I have done by testing and uncomment the publish part out.

@nimanch nimanch changed the title Automation Release Package Publication Automate Release Package Publication Jan 7, 2022
@kodiakhq kodiakhq bot merged commit b91cbe3 into Azure:release/1.2 Jan 7, 2022
@nimanch nimanch deleted the personal/nimanch/automatepublish branch January 7, 2022 23:45
kodiakhq bot pushed a commit that referenced this pull request Jan 14, 2022
This PR Manually Ports over changes from 
1. #5983 
2. #5963 

Waiting for this Test Run to pass
1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results

## Azure IoT Edge PR checklist:
kodiakhq bot pushed a commit that referenced this pull request Jan 14, 2022
This PR brings changes from
1. #5963 
2. #5983 

to release/1.1. Manual Changes had to be done due to significant difference in how packages are build in 1.2 vs 1.1.

This PR is a follow up of
1. #5995 

Testing
1. Hardcoded Version and Branch and verified that Packages are uploaded to Github : https://dev.azure.com/msazure/One/_build/results?buildId=50827929&view=results
2. Verified Can run repo client tool and query status: https://dev.azure.com/msazure/One/_build/results?buildId=50830155&view=results


## Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

### General Guidelines and Best Practices
- [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing).
- [x] Title of the pull request is clear and informative.
- [x] Description of the pull request includes a concise summary of the enhancement or bug fix.

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
- Description of the pull request includes 
	- [x] concise summary of tests added/modified
	- [x] local testing done.  

### Draft PRs
- Open the PR in `Draft` mode if it is:
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.

_Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
lt72 pushed a commit to lt72/iotedge that referenced this pull request Jan 31, 2022
This PR Manually Ports over changes from 
1. Azure#5983 
2. Azure#5963 

Waiting for this Test Run to pass
1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results

## Azure IoT Edge PR checklist:
damonbarry pushed a commit to damonbarry/iotedge that referenced this pull request Apr 15, 2022
This PR Manually Ports over changes from 
1. Azure#5983 
2. Azure#5963 

Waiting for this Test Run to pass
1. https://dev.azure.com/msazure/One/_build/results?buildId=50830892&view=results

## Azure IoT Edge PR checklist:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants